Updated cmake files to use CMAKE_INSTALL_LIBDIR instead of AIMET_INSTALL_DIR #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer to use idiomatic CMAKE_INSTALL_PREFIX for installation location, to be provided by the user, and GNUInstallDirs. This changes all install destinations to relative paths instead of absolute paths, as recommended by CMake reference. Also fix small directory bug in Examples tarball creation. Signed-off-by: Michael Hofmann <quic_michof@quicinc.com>
…d that can be unpacked. NB, the CMakeLists.txt and README.md files in the Examples directory will be included in the tarball even thogh they probably shouldn't. This does not appear to be a regression from the previous (non-functional) version. Signed-off-by: Michael Hofmann <quic_michof@quicinc.com>
Signed-off-by: Michael Hofmann <quic_michof@quicinc.com>
Signed-off-by: Michael Hofmann <quic_michof@quicinc.com>
abhikhobare
approved these changes
Sep 11, 2024
quic-akhobare
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.