Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently v2 encoding analyzer asserts
scale >= torch.finfo(...).tiny
.However, this
tiny
is the smallest positive normal number, which is numerically extremely unstableFix
Use
torch.finfo.eps
as minimum scale instead.eps
is a much more moderate value thantiny
, and hence more numerically stable(p.s. 1.0 / (2**16-1) is equal to 1.53e-05, which is still larger than float32 eps)