[feat] Adding UPerNet #926
Open
+234
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qubvel
reviewed
Sep 17, 2024
There was a problem hiding this comment.
Hi @brianhou0208, thanks a lot for working on this! Looks good to me, a few general notes/questions
- Can you please use more verbose variable naming, e.g.
ch->channels,h -> height(it is not hold over the repo, but would be nice to have it) - Please, add the model to the docs/ and README.md
- Did you have a chance to train it with any notebook example?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I tried to add UperNet before. This may not be the best version. Maybe you can have a look.
@GrantorShadow @jawi289o
Issue
#906
Reference