Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More idiomatic scala code #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

satybald
Copy link

PR improves readability of code base by introducing scala pattern matching idioms and couple code formatting issues.

@satybald
Copy link
Author

@iamrohit @vrajat what do you think about PR?

@satybald
Copy link
Author

@iamrohit @vrajat any chance to look at the PR? It has been open for two weeks now...

Copy link

@venkata91 venkata91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these changes looks good to me. It helps in having cleaner and readable code

@satybald
Copy link
Author

satybald commented Jul 4, 2018

@venkata91 thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants