Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reactive MS SQL client extension #18311

Merged
merged 7 commits into from
Jul 6, 2021
Merged

Add reactive MS SQL client extension #18311

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
737b982
MS SQL extension
tsegismont Jul 1, 2021
65ed225
Updates after running update-extension-dependencies.sh
tsegismont Jul 1, 2021
f8b8c28
Expand Microsoft SQL Server name
tsegismont Jul 2, 2021
d1759c0
Remove redundant stacktrace from the test console
tsegismont Jul 2, 2021
614db32
MSSQL Reactive Client SSL not supported yet
tsegismont Jul 2, 2021
40baa0d
TDS Packet size configurable with Vert.x 4.1.1
tsegismont Jul 2, 2021
c2d0747
Update MSSQL container setup to avoid timeouts
tsegismont Jul 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions extensions/reactive-mssql-client/deployment/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

<properties>
<reactive-mssql.url>vertx-reactive:sqlserver://localhost:1433</reactive-mssql.url>
<mssql.image>mcr.microsoft.com/mssql/server:2019-latest</mssql.image>
<mssql.image>mcr.microsoft.com/mssql/server:2019-CU8-ubuntu-16.04</mssql.image>
</properties>

<dependencies>
Expand Down Expand Up @@ -127,9 +127,6 @@
<name>${mssql.image}</name>
<alias>quarkus-test-mssql</alias>
<run>
<network>
<mode>bridge</mode>
</network>
<ports>
<port>1435:1433</port>
</ports>
Expand All @@ -143,13 +140,9 @@
<color>cyan</color>
</log>
<wait>
<!-- good docs found at: http://dmp.fabric8.io/#build-healthcheck -->
<tcp>
<mode>direct</mode>
<ports>
<port>1433</port>
</ports>
</tcp>
<log>SQL Server is now ready for client connections</log>
<!-- Unfortunately booting this is slow, needs to set a generous timeout: -->
<time>40000</time>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks! Let's see if CI managed to run it now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one failure but it looks unrelated

</wait>
</run>
</image>
Expand Down
15 changes: 4 additions & 11 deletions integration-tests/reactive-mssql-client/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

<properties>
<reactive-mssql.url>vertx-reactive:sqlserver://localhost:1433</reactive-mssql.url>
<mssql.image>mcr.microsoft.com/mssql/server:2019-latest</mssql.image>
<mssql.image>mcr.microsoft.com/mssql/server:2019-CU8-ubuntu-16.04</mssql.image>
</properties>

<dependencies>
Expand Down Expand Up @@ -166,9 +166,6 @@
<name>${mssql.image}</name>
<alias>quarkus-test-mssql</alias>
<run>
<network>
<mode>bridge</mode>
</network>
<ports>
<port>1435:1433</port>
</ports>
Expand All @@ -182,13 +179,9 @@
<color>cyan</color>
</log>
<wait>
<!-- good docs found at: http://dmp.fabric8.io/#build-healthcheck -->
<tcp>
<mode>direct</mode>
<ports>
<port>1433</port>
</ports>
</tcp>
<log>SQL Server is now ready for client connections</log>
<!-- Unfortunately booting this is slow, needs to set a generous timeout: -->
<time>40000</time>
</wait>
</run>
</image>
Expand Down