-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reactive MS SQL client extension #18311
Conversation
tsegismont
commented
Jul 1, 2021
- runtime/deployment modules
- integration tests (including native mode)
- datasources docs
...-mssql-client/deployment/src/test/java/io/quarkus/reactive/mssql/client/DevModeResource.java
Outdated
Show resolved
Hide resolved
This workflow status is outdated as a new workflow run has been triggered. |
@DavideD could you follow up with integration tests using MS SQL + Hibernate Reactive ? |
Do you mean integration tests for Quarkus? Sure, we are having some trouble with the MS SQL Client on Hibernate Reactive at the moment, but as soon as it has been fixed, I will add them |
- runtime/deployment modules - integration tests (including native mode) - datasources docs
b03500c
to
40baa0d
Compare
Thank you all for the review. I addressed the concerns and rebased on |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 40baa0d
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/elytron-undertow✖ |
Looks like the failures are related:
|
it's a DB bootstrap timeout:
|
@tsegismont could you copy the infrastructure from the pom.xml in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. However, validation by Sanne would be great (as I don't know much about databases anyway).
@Sanne good idea, I will do it for both the integration tests and the deployment module tests. |
Took example from JPA-MSSQL integration tests module.
</tcp> | ||
<log>SQL Server is now ready for client connections</log> | ||
<!-- Unfortunately booting this is slow, needs to set a generous timeout: --> | ||
<time>40000</time> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks! Let's see if CI managed to run it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one failure but it looks unrelated
Failing Jobs - Building c2d0747
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/vertx-http/deployment✖ |
awesome, let's merge this. Many thanks! |