Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Quarkus-cli flacky test #321

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Conversation

pjgg
Copy link
Contributor

@pjgg pjgg commented Oct 28, 2021

Copy link
Contributor

@Sgitario Sgitario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds odd to me. The app.start() should be consistent and if's flaky, it should be fixed internally.

What is happening here is that for some reason, it fails to start at first and then it retries several times until eventually it starts ok.

Copy link
Contributor

@Sgitario Sgitario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix seems like a workaround for CLI but that now affects all the scenarios in the test framework with possible side effects.
We should investigate why this test starts behaving flacky to indeed solve the issue.

Copy link
Contributor

@Sgitario Sgitario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the changes, but add a comment with a link to the upstream issue / or pr to put some context around why this was necessary.

@Sgitario Sgitario merged commit 9126dcb into quarkus-qe:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants