-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RuntimeException is thown when I try to re-start an updated app from Quarkus client #21070
Comments
I am unclear from the description about which version is affected by this problem. Can you please clarify? |
999-SNAPSHOT |
I was not able to reproduce this on an example application. What are the exact steps one needs to follow to reproduce this based on your testsuite? |
Remember that
You should change it in order to point to your latest |
Surely running the entire testsuite just to see this one failure is not necessary :) |
In case, I could not reproduce the problem. |
We could not reproduce the issue anymore on upstream so let's close it from now!. |
Thanks for the info |
Describe the bug
Quarkus Core Upstream (999-SNAPSHOT).
Quarkus Client Upstream (999-SNAPSHOT)
We have a reproducer where we are checking the Quarkus client behavior. Basically, we are creating an app from scratch and then adding
quarkus-smallrye-openapi
, then start the app check that everything is fine, stop the app, removequarkus-smallrye-openapi
extension and start the app again, and here in the last step we are getting the following exception:Note that used to work as expected indeed is working fine with Quarkus 2.3.0.Final, or is working fine if you use Quarkus upstream but Quarkus Client 2.3.0.Final
I think that is something related to this commit: https://github.com/quarkusio/quarkus/pull/20998/files#diff-b4cbc080dba18bd5f82d2ece4ad078b684bfe808602e4a38e16d7de137d065dcR37 and also looks that there is a race condition in somewhere because from now we have fixed the scenario by adding a sleep.
To me that is important is to be sure that there is no a run condition on this method: https://github.com/quarkusio/quarkus/pull/20998/files#diff-b4cbc080dba18bd5f82d2ece4ad078b684bfe808602e4a38e16d7de137d065dcR37
Expected behavior
Be able to add and remove an extension by Quarkus client (even if is executed by a script) and the app should start without any exception.
Actual behavior
Currently, you could have a look at our GitHub actions: https://github.com/quarkus-qe/quarkus-test-framework/runs/4032194711?check_suite_focus=true
How to Reproduce?
quarkus-qe/quarkus-test-suite#361
cmd:
mvn clean verify -Dall-modules -Dinclude.quarkus-cli-tests -Dts.quarkus.cli.cmd=/tmp/quarkus-dev-cli -pl quarkus-cli
Where
ts.quarkus.cli.cmd
is pointing to this script:Basically, I have compiled Quarkus-cli Upstream and used it in my test by this way.
Output of
uname -a
orver
No response
Output of
java -version
No response
GraalVM version (if different from Java)
No response
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --version
orgradlew --version
)No response
Additional information
No response
The text was updated successfully, but these errors were encountered: