Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Java for JBang purposes in the Flaky test workflow #1339

Conversation

michalvavrik
Copy link
Member

Summary

I run test here quarkus-qe/quarkus-test-suite#2050 (because workflows are very similar and the script is same) and it seems that I need to setup Java for the JBang https://github.com/quarkus-qe/quarkus-test-suite/actions/runs/11041992883/job/30673453268. I didn't experience this locally for obvious reasons.

Same as: quarkus-qe/quarkus-test-suite#2051

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik force-pushed the feature/add-java-setup-to-flaky-workflow branch from bb501c2 to e3c4e86 Compare September 26, 2024 08:14
@michalvavrik michalvavrik marked this pull request as draft September 26, 2024 09:20
@michalvavrik michalvavrik force-pushed the feature/add-java-setup-to-flaky-workflow branch from e3c4e86 to 660ae6d Compare September 26, 2024 09:27
@michalvavrik michalvavrik marked this pull request as ready for review September 26, 2024 09:27
@michalvavrik
Copy link
Member Author

michalvavrik commented Sep 26, 2024

@rsvoboda here is a prove it works in the TS quarkus-qe/quarkus-test-suite#2050 (comment)

I realized I need to rename individual artifacts to avoid collisions in naming, so I'll rename these files:

Run gh run download $WORKFLOW_ID -n flaky-run-report-linux-jvm-latest || true
error downloading flaky-run-report-linux-native-latest: error extracting zip archive: error extracting "flaky-run-report.json": open flaky-run-report.json: file exists
error downloading flaky-run-report-windows-jvm-latest: error extracting zip archive: error extracting "flaky-run-report.json": open flaky-run-report.json: file exists

but that will be done separately because these are different workflows (let's not run CI again for this); I will try that first in the TS etc. So I suggest to proceed with this one.

@rsvoboda rsvoboda merged commit 8387845 into quarkus-qe:main Sep 26, 2024
8 checks passed
@michalvavrik michalvavrik deleted the feature/add-java-setup-to-flaky-workflow branch September 26, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants