Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.4.z] Fix runtime config properties recording in OpenShift #1120

Merged
merged 1 commit into from
May 9, 2024
Merged

[1.4.z] Fix runtime config properties recording in OpenShift #1120

merged 1 commit into from
May 9, 2024

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented May 8, 2024 •
edited
Loading

Summary

Backports #1094 as io.quarkus.qe.OpenShiftDockerBuildIT, io.quarkus.qe.OpenShiftExtensionIT are failing quite a lot now (in 1.4.z CI) and I think maybe, it could be related to quarkusio/quarkus#40079.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Backport
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member Author

run tests

@michalvavrik
Copy link
Member Author

michalvavrik commented May 8, 2024 •
edited
Loading

The OpenShiftStrimziOperatorKafkaWithoutRegistryMessagingIT failure in JVM & native is not related, I also saw it here #1117. We need to have a look into that, but it's not related.

@michalvavrik michalvavrik requested a review from mjurc May 8, 2024 19:22
@michalvavrik
Copy link
Member Author

Update - the operator test is fixed here #1121

mjurc
mjurc approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjurc mjurc merged commit 781b924 into quarkus-qe:1.4.z May 9, 2024
7 of 9 checks passed
@michalvavrik michalvavrik deleted the backport-1.4.z-runtime-props-fix branch May 9, 2024 15:09
@michalvavrik michalvavrik mentioned this pull request May 9, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjurc mjurc mjurc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalvavrik @mjurc