Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime config properties recording in OpenShift #1094

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Apr 20, 2024

Summary

Fixes openshift-tf-jvm-nightly and openshift-tf-native-nightly. (full disclosure: I also mentioned they can be flaky due to network blips in at least one run of great many I executed, and there was many of blocking warnings, but I suppose that would be a separate issue if repeated)

OpenShiftExtensionIT and OpenShiftDockerBuildIT are failing with Quarkus 3.8.4 (but not 3.8.3) and 999-SNAPSHOT as runtime values recorder at build time are not kept any more quarkusio/quarkus#39604. In OpenShift, runtime system properties set to mvn when we do .withProperty("quarkus.management.port", "9002") are not propagated so we need to copy them always to application properties. This behavior is IMHO correct because the change in Quarkus solved leaking of sensitive information.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik mentioned this pull request Apr 20, 2024
11 tasks
@michalvavrik michalvavrik force-pushed the feature/fix-ocp-runtime-props-recording branch 2 times, most recently from 115b37d to 25cf512 Compare April 21, 2024 10:04
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik force-pushed the feature/fix-ocp-runtime-props-recording branch from 25cf512 to d40e511 Compare April 21, 2024 17:21
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik force-pushed the feature/fix-ocp-runtime-props-recording branch from d40e511 to 1e03995 Compare April 21, 2024 18:49
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik requested a review from mjurc April 21, 2024 20:33
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the prompt fix.

@mjurc mjurc merged commit 6e50b5f into quarkus-qe:main Apr 22, 2024
10 checks passed
@michalvavrik michalvavrik deleted the feature/fix-ocp-runtime-props-recording branch April 22, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants