Adds functionality for viewing and debugging swap networks #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strilanc
approved these changes
Jul 16, 2019
bryano
changed the title
bryano
commented
Jul 16, 2019
| def uses_consistent_swap_gate(circuit: circuits.Circuit, | ||
| swap_gate: ops.Gate) -> bool: | ||
| for op in circuit.all_operations(): | ||
| gate = ops.op_gate_of_type(op, Type[PermutationGate]) |
There was a problem hiding this comment.
Any thoughts on how to do the typing here? Mypy doesn't like instantiating a typevar with an abstract class.
There was a problem hiding this comment.
I reverted so the tests pass, but if you see a way to use op_gate_of_type that mypy finds acceptable, let me know.
Strilanc
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.