Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove negative space + UI improvements #1795

Open
wants to merge 15 commits into
base: qa
Choose a base branch
from
Open

Remove negative space + UI improvements #1795

wants to merge 15 commits into from

Conversation

davidfig
Copy link
Collaborator

@davidfig davidfig commented Aug 25, 2024

This PR:

  • removes negative space: we are disabling it, but keeping it as part of the grid for now. This allows people to move their content away from the negative space but not add new content there (or possibly we allow it for margin work?)
  • add a sheet size to the grid to limit the parts of the sheet that are visually usable. The sheet size will grow as content is added.

Decisions:

  • what do we do with our coordinate system? do we revert to Excel or keep the (x, y). At the minimum, we should maintain the relative (x,y). We also have already expanded it, eg, (col=5). We could change that to (col=A)
  • gridlines
  • headings
  • remove axis lines
  • setSheetSize (limiting the number of columns and rows)
  • automatically expand sheet size when set and less than the content
  • decide what to do with cell references (revert to Excel or keep (x,y))
  • background fill w/grid lines
  • viewport snapping
  • remove mouse and keyboard interaction (except drop) when in negative space
    • mouse movement
    • clicking on cell
    • autocomplete
    • keyboard movement
  • handle dropping and moving into negative space (dialog warning that this will offset the entire sheet)
  • bounce when too far into negative space (except drop)
  • ensure x,y are always positive

Copy link

qa-wolf bot commented Aug 25, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Aug 25, 2024
Copy link

vercel bot commented Aug 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Sep 10, 2024 5:18pm

@davidfig davidfig added the prototype exploring an idea that can be played with label Aug 25, 2024
@davidfig davidfig marked this pull request as ready for review August 25, 2024 13:24
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1795 August 25, 2024 13:27 Inactive
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 93.92265% with 11 lines in your changes missing coverage. Please review.

Project coverage is 90.93%. Comparing base (dfbadc7) to head (17c4457).

Files with missing lines Patch % Lines
...dratic-core/src/controller/operations/operation.rs 0.00% 6 Missing ⚠️
quadratic-core/src/controller/operations/sheets.rs 87.50% 3 Missing ⚠️
...ller/execution/execute_operation/execute_sheets.rs 95.23% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##               qa    #1795    +/-   ##
========================================
  Coverage   90.92%   90.93%            
========================================
  Files         208      208            
  Lines       43349    43514   +165     
========================================
+ Hits        39415    39569   +154     
- Misses       3934     3945    +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1795 August 25, 2024 15:00 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1795 August 26, 2024 13:00 Inactive
@davidfig davidfig changed the title Remove negative space Remove negative space + UI improvements Aug 26, 2024
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1795 August 26, 2024 16:19 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1795 August 26, 2024 16:23 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed prototype exploring an idea that can be played with
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants