This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Unversion metrics and health #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
May 30, 2018 17:08
FredrikFolkesson
commented
Jun 2, 2018
doc/api-doc.yml
Outdated
| @@ -1,13 +1,12 @@ | |||
| info: | |||
| title: A Qlik Associative Engine discovery service | |||
| version: 0.1.2 | |||
| version: 0.2.2 | |||
There was a problem hiding this comment.
I guess this should be a change of API version since we change the paths?
FredrikFolkesson
commented
Jun 2, 2018
| @@ -26,15 +25,15 @@ paths: | |||
| get: | |||
| description: Returns metrics of the Mira service | |||
| produces: | |||
| - application/json; charset=utf-8 | |||
| - application/json | |||
There was a problem hiding this comment.
Changed to only application/json since that is what our metrics library gives out.
There was a problem hiding this comment.
Also JSON according to the spec must be utf-8 so it should be implicit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #274 and #275
This PR removes /v1/metrics and /v1/health