Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

Changes to orchestration data is reflected in response #262

Merged
merged 3 commits into from
Apr 5, 2018
Merged

Changes to orchestration data is reflected in response #262

merged 3 commits into from
Apr 5, 2018

Conversation

gabbaxx
Copy link
Contributor

@gabbaxx gabbaxx commented Mar 28, 2018

Closes #261

@gabbaxx gabbaxx self-assigned this Mar 28, 2018
janmiderback
janmiderback approved these changes Mar 28, 2018
View reviewed changes
Copy link
Contributor

@janmiderback janmiderback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just a minor comment

src/EngineEntry.js Outdated
@@ -85,6 +85,16 @@ class EngineEntry {
}
}

updateOrchestrationProperties(properties) {
const keys = Object.keys(properties);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer Object.keys(properties).forEach((key) => ...)

wennmo
wennmo approved these changes Mar 29, 2018
View reviewed changes
Copy link
Member

@wennmo wennmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gabbaxx gabbaxx merged commit 8e4c93a into master Apr 5, 2018
@gabbaxx gabbaxx deleted the refresh-orchestration-data branch April 5, 2018 06:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janmiderback janmiderback janmiderback approved these changes

@wennmo wennmo wennmo approved these changes

Assignees

@gabbaxx gabbaxx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabbaxx @janmiderback @wennmo