This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Always require a RELEASE_TYPE when creating a release #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peol
approved these changes
Feb 16, 2018
Who would make such a silly misstake? :P |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
release.shused for creating Mira releases assumed a patch release if a type was not given.This could lead to unwanted releases if e.g. running
./release.sh ?. Removed the assumption of patch and the script will now exit ifRELEASE_TYPEis not set or is invalid, and also print usage instructions.