This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Change default discovery interval for Mira to 10 seconds #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current default discovery interval for Mira is 1 second. Since not many use-cases are so reliant on detecting new engines in an orchestration, lets increase the value to 10 seconds instead. The interval is still configurable from env variable
MIRA_ENGINE_DISCOVERY_INTERVAL, which is used in the tests.Also changed the initial value for
discoverySuccessfulto true, otherwise orchestration api failures on startup of the service will not be logged.