This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Filtering out non-running containers/tasks/pods #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmiderback
commented
Dec 19, 2017
| @@ -43,12 +43,19 @@ class KubernetesClient { | |||
| */ | |||
| static async listEngines() { | |||
| const pods = await kubeHttpGet(`/api/v1/pods?labelSelector=${Config.discoveryLabel}`); | |||
| const validPods = pods.items.filter( | |||
There was a problem hiding this comment.
runningPods is a better name
wennmo
approved these changes
Dec 19, 2017
| const engine = { | ||
| ip: pod.status.podIP, | ||
| }; | ||
| const engine = { ip: pod.status.podIP }; |
There was a problem hiding this comment.
will pods in state running always have an IP?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not trust information from Docker containers, Swarm tasks, or K8s pods unless the item is reported as successfully be running.
Also, added logging on when we discard, non-running items. Added debug info on all discovered items and their JSON content. Convenient to have at
debuglogging level.Unit test data extended with non-running items to make sure the selection mech works.