This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Update logging in Mira #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peol
approved these changes
Oct 27, 2017
| @@ -36,7 +35,6 @@ process.on('unhandledRejection', onUnhandledError); | |||
|
|
|||
| app | |||
| .use(swagger2koa.ui(document, '/openapi')) | |||
| .use(koaLoggerWinston(logger)) | |||
There was a problem hiding this comment.
Was there no way to set the koa logger to log on debug level? It could be useful on debug level
There was a problem hiding this comment.
Not that I could find. If we want to log the /engines endpoint on info anyway, this was the easiest way I found. Are there other benefits of using koa-logger?
There was a problem hiding this comment.
Seems to be hard-coded to info for non-error codes. Let's remove then.
| @@ -16,7 +16,7 @@ class Logger { | |||
| timestamp: true, | |||
| json: true, | |||
| stringify: true, | |||
| level: process.env.LOG_LEVEL || 'silly', | |||
| level: process.env.MIRA_LOG_LEVEL || 'info', | |||
There was a problem hiding this comment.
Is this "standard"? Or, should it be MIRA_MINIMUM_LOG_LEVEL or similar?
There was a problem hiding this comment.
In my opinion MIRA_LOG_LEVEL should be sufficient. Haven't seen any standard regarding this, but didn't dig to deep :)
janmiderback
approved these changes
Oct 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following:
infoThis closes #168