Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint #620

Merged
merged 1 commit into from
May 17, 2024
Merged

Fix lint #620

merged 1 commit into from
May 17, 2024

Conversation

t-imamichi
Copy link
Collaborator

Summary

pylint 3.2.0 https://github.com/pylint-dev/pylint/releases/tag/v3.2.0 released on May 14 causes some lint errors.
This PR fixes them.

Details and comments

@t-imamichi t-imamichi added type: ci Related to CI changes stable backport potential The bug might be minimal and/or import enough to be port to stable labels May 17, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9124474668

Details

  • 2 of 6 (33.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 92.954%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_optimization/translators/gurobipy.py 0 4 0.0%
Totals Coverage Status
Change from base Build 9003588704: -0.08%
Covered Lines: 4512
Relevant Lines: 4854
💛 - Coveralls

woodsp-ibm
woodsp-ibm approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx for doing this. I had only managed to do ML and algorithms so far, so having this done is great!

@woodsp-ibm woodsp-ibm merged commit c190367 into qiskit-community:main May 17, 2024
16 checks passed
mergify bot pushed a commit that referenced this pull request May 17, 2024
@t-imamichi @mergify
Fix lint (#620)
15d0541 
(cherry picked from commit c190367)
@mergify mergify bot mentioned this pull request May 17, 2024
Merged
@t-imamichi t-imamichi deleted the lint branch May 17, 2024 13:04
mergify bot added a commit that referenced this pull request May 17, 2024
@mergify @t-imamichi
Fix lint (#620) (#621)
4727d91 
(cherry picked from commit c190367)

Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodsp-ibm woodsp-ibm woodsp-ibm approved these changes

@stefan-woerner stefan-woerner Awaiting requested review from stefan-woerner stefan-woerner is a code owner

@dthuerck dthuerck Awaiting requested review from dthuerck

@Sofranac-Boro Sofranac-Boro Awaiting requested review from Sofranac-Boro

Assignees
No one assigned
Labels
stable backport potential The bug might be minimal and/or import enough to be port to stable type: ci Related to CI changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@t-imamichi @coveralls @woodsp-ibm