Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump black version #617

Merged
merged 2 commits into from
May 8, 2024
Merged

bump black version #617

merged 2 commits into from
May 8, 2024

Conversation

t-imamichi
Copy link
Collaborator

@t-imamichi t-imamichi commented May 8, 2024 •
edited
Loading

Summary

Since qiskit uses black 24.1, this PR updates the black version for qiskit optimization.

Qiskit/qiskit#11701

Details and comments

@t-imamichi t-imamichi added the stable backport potential The bug might be minimal and/or import enough to be port to stable label May 8, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9001841075

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.029%
Totals Coverage Status
Change from base Build 9001822816: 0.0%
Covered Lines: 4511
Relevant Lines: 4849
💛 - Coveralls

@t-imamichi t-imamichi marked this pull request as ready for review May 8, 2024 13:03
@woodsp-ibm
Copy link
Member

Thanks for doing this. It was done for Nature already qiskit-community/qiskit-nature#1357 and I did it for Algorithms so this is another repo done too.

@woodsp-ibm woodsp-ibm merged commit 5d20d2e into qiskit-community:main May 8, 2024
16 checks passed
mergify bot pushed a commit that referenced this pull request May 8, 2024
@t-imamichi @mergify
bump black version (#617)
2e22baf 
Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
(cherry picked from commit 5d20d2e)
@mergify mergify bot mentioned this pull request May 8, 2024
Merged
@t-imamichi t-imamichi deleted the black branch May 8, 2024 14:31
mergify bot added a commit that referenced this pull request May 8, 2024
@mergify @t-imamichi
bump black version (#617) (#619)
23b565f 
Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
(cherry picked from commit 5d20d2e)

Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodsp-ibm woodsp-ibm woodsp-ibm approved these changes

@stefan-woerner stefan-woerner Awaiting requested review from stefan-woerner stefan-woerner is a code owner

@dthuerck dthuerck Awaiting requested review from dthuerck

@Sofranac-Boro Sofranac-Boro Awaiting requested review from Sofranac-Boro

Assignees
No one assigned
Labels
stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@t-imamichi @coveralls @woodsp-ibm