Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin ipython #500

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Pin ipython #500

merged 1 commit into from
Apr 28, 2023

Conversation

t-imamichi
Copy link
Collaborator

@t-imamichi t-imamichi commented Apr 28, 2023

Summary

ipython 8.13 dropped python 3.8 support and causes CI breakage.
https://github.com/Qiskit/qiskit-optimization/actions/runs/4831005912/jobs/8607891037

This PR pins ipython version.

See ipython/ipython#14023

Details and comments

@t-imamichi t-imamichi added the type: ci Related to CI changes label Apr 28, 2023
Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it just released. Imagine we will hit this same CI issue elsewhere too

@t-imamichi t-imamichi merged commit cbb0c5b into qiskit-community:main Apr 28, 2023
@t-imamichi t-imamichi deleted the pin-ipython branch April 28, 2023 14:00
@woodsp-ibm
Copy link
Member

We could backport this too in case we need/want to update docs before the next release so CI will run on stable ok.

@t-imamichi
Copy link
Collaborator Author

Thanks. We should backport this.

@t-imamichi t-imamichi added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Apr 28, 2023
mergify bot pushed a commit that referenced this pull request Apr 28, 2023
(cherry picked from commit cbb0c5b)
@mergify mergify bot mentioned this pull request Apr 28, 2023
mergify bot added a commit that referenced this pull request May 1, 2023
(cherry picked from commit cbb0c5b)

Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stable backport potential The bug might be minimal and/or import enough to be port to stable type: ci Related to CI changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants