Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecates Opflow and QuantumInstance #499

Merged
merged 8 commits into from
Apr 28, 2023
Merged

Deprecates Opflow and QuantumInstance #499

merged 8 commits into from
Apr 28, 2023

Conversation

t-imamichi
Copy link
Collaborator

@t-imamichi t-imamichi commented Apr 26, 2023 •
edited
Loading

Summary

This PR deprecates Opflow and QuantumInstance related parts.
This PR also refactors some codes to suppress Opflow/QuantumInstance deprecation warnings by using SparsePauliOp and self.assertWarns as much as possible.

Qiskit/qiskit#10030 is also necessary to suppress more opflow deprecation warnings because QAOA currently converts SparsePauliOp into Opflow internally.

Details and comments

@t-imamichi t-imamichi added this to the 0.6.0 milestone Apr 26, 2023
@coveralls
Copy link

coveralls commented Apr 26, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4826890639

  • 17 of 17 (100.0%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 92.165%
Files with Coverage Reduction New Missed Lines %
qiskit_optimization/algorithms/grover_optimizer.py 3 93.66%
Totals Coverage Status
Change from base Build 4805115199: -0.005%
Covered Lines: 4364
Relevant Lines: 4735
💛 - Coveralls

t-imamichi and others added 2 commits April 27, 2023 12:37
@t-imamichi @woodsp-ibm
Update qiskit_optimization/translators/ising.py
da47e98 
Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
@t-imamichi
update test_ising and add reno
0d83fb3
woodsp-ibm
woodsp-ibm approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@t-imamichi t-imamichi added Changelog: Deprecation Include in Deprecated section of changelog automerge labels Apr 28, 2023
@t-imamichi t-imamichi merged commit 75d9898 into qiskit-community:main Apr 28, 2023
@t-imamichi t-imamichi deleted the reduce-opflow-warnings branch April 28, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodsp-ibm woodsp-ibm woodsp-ibm approved these changes

@stefan-woerner stefan-woerner Awaiting requested review from stefan-woerner stefan-woerner is a code owner

Assignees
No one assigned
Labels
automerge Changelog: Deprecation Include in Deprecated section of changelog
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@t-imamichi @coveralls @woodsp-ibm