Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GroverOptimizer with Sampler #451

Merged
merged 3 commits into from
Dec 6, 2022

Conversation

t-imamichi
Copy link
Collaborator

@t-imamichi t-imamichi commented Dec 5, 2022

Summary

Simplified Sampler code for GroverOptimizer by interpreting quasi distribution with binary_probabilities method.

main

> python -m unittest test.algorithms.test_grover_optimizer.TestGroverOptimizer.test_samples_and_raw_samples_3_sampler
(88.55s)
.
----------------------------------------------------------------------
Ran 1 test in 88.545s

OK

this PR

> python -m unittest test.algorithms.test_grover_optimizer.TestGroverOptimizer.test_samples_and_raw_samples_3_sampler
.
----------------------------------------------------------------------
Ran 1 test in 3.884s

OK

Details and comments

@coveralls
Copy link

coveralls commented Dec 5, 2022

Pull Request Test Coverage Report for Build 3625827246

  • 13 of 14 (92.86%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 92.065%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_optimization/algorithms/optimization_algorithm.py 3 4 75.0%
Totals Coverage Status
Change from base Build 3617491017: 0.003%
Covered Lines: 4339
Relevant Lines: 4713

💛 - Coveralls

@mergify mergify bot merged commit 8a1f88d into qiskit-community:main Dec 6, 2022
@t-imamichi t-imamichi deleted the fix-grover branch December 6, 2022 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants