Override classmethod supports_aux_operators in VQEProgram #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasys
requested review from
manoelmarques,
pbark,
stefan-woerner,
t-imamichi and
woodsp-ibm
as code owners
|
|
Cryoris
reviewed
Aug 4, 2021
Cryoris
suggested changes
Aug 4, 2021
|
Since VQEProgram in Qiskit Nature is the same as the one here, do you fancy making this fix there too once this one is done here? |
@Cryoris I added two tests and a release note. Let me know, if it's good or if i should change something. |
Cryoris
reviewed
Aug 10, 2021
t-imamichi
added
the
stable backport potential
|
@lasys Thank you for your contribution. Could you check out CLA? #223 (comment) |
t-imamichi
reviewed
Aug 16, 2021
t-imamichi
reviewed
Aug 16, 2021
Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
t-imamichi
approved these changes
Aug 16, 2021
mergify bot
pushed a commit
that referenced
this pull request
Aug 16, 2021
* override supports_aux_operators * removed docstring * added tests * added tests * add release note * reordered imports + merged tests into one * added method docstring * fixed formatting * Update test/algorithms/test_min_eigen_optimizer.py Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> * Update test/algorithms/test_min_eigen_optimizer.py Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> (cherry picked from commit 103db34)
manoelmarques
pushed a commit
that referenced
this pull request
Aug 16, 2021
* override supports_aux_operators * removed docstring * added tests * added tests * add release note * reordered imports + merged tests into one * added method docstring * fixed formatting * Update test/algorithms/test_min_eigen_optimizer.py Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> * Update test/algorithms/test_min_eigen_optimizer.py Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> (cherry picked from commit 103db34) Co-authored-by: lasys <43267480+lasys@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #222
Details and comments