-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Optimizer
s as input to VQEProgram
#290
Allow Optimizer
s as input to VQEProgram
#290
Conversation
So this is a feature rather than any bug fix then. I see you put a high priority label on the issue which is why I am asking. As a feature this would go out in the next release unless somehow its creating critical problems/issues out there now. I assume you will be updating the optimization repo equivalently. If we need these to stay the same out there so users can use the one in Nature and/or the one in Optimization the same way then I guess things need to be coordinated/sorted out, since I presently would have expected a Nature release in advance of the next Optimization one - unless we start talking bug fix releases. |
It would be better to get this out before the next feature release, right, so it seems more like a bugfix 😉 I synced with @pbark and looks like we can do a minor/bugfix release soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM!
* allow Optimizers as optimizer inputs * Update releasenotes/notes/vqeprogram-optimizers-cd23307c10fcd15b.yaml Co-authored-by: Panagiotis Barkoutsos <pbarkoutsos@gmail.com> (cherry picked from commit e6a2dfd)
* allow Optimizers as optimizer inputs * Update releasenotes/notes/vqeprogram-optimizers-cd23307c10fcd15b.yaml Co-authored-by: Panagiotis Barkoutsos <pbarkoutsos@gmail.com> (cherry picked from commit e6a2dfd) Co-authored-by: Julien Gacon <jules.gacon@googlemail.com>
* allow Optimizers as optimizer inputs * Update releasenotes/notes/vqeprogram-optimizers-cd23307c10fcd15b.yaml Co-authored-by: Panagiotis Barkoutsos <pbarkoutsos@gmail.com>
Summary
Fixes #289.
Details and comments
Dictionaries are still supported since some tutorials first need to be updated to use optimizers.