[Stable] Fix test for MAC ARM and pin torch #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodsp-ibm
requested review from
adekusar-drl,
smens,
edoaltamura,
oscar-wallis,
OkuyanBoga and
Benjamin-Symons
as code owners
woodsp-ibm
changed the title
Pull Request Test Coverage Report for Build 9063282699Details
💛 - Coveralls |
edoaltamura
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stable CI MAC is running ARM now as recent github runner changed macos_latest to ARM. While we had specifically added ARM CI to main #779 (which should be reviewed now latest if no longer X86) it was not backported to stable, as at the time it added more CI for ARM. This fixes the test that would fail under ARM.
Also pinning torch to avoid a UTF8 issue in Windows as was done by #796.
See #800, which attempted to backport a black update and failed due to the above, which has more details on the above and links to the respective PRs and new issue around ARM and CI
Details and comments
As this takes care of what #802 does, which does not pass CI without the test fix that is also here, that PR can simply be closed after this is merged.