This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Fix ignis without optional requirements installed #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreinish
added
stable-backport-potential
Changelog: Bugfix
mtreinish
changed the title
In qiskit-community#500 type hints were added for the plotting functions using the optional matplotlib dependencies. This breaks ignis installations without matplotlib present since it's an optional dependency. Since type hints are really just for documentation and not necessary this commit just removes those problematic hints and uses the docstring to document the types. At the same time the testing job verifying ignis works without any optional dependencies that was lost in the migration from travis to github actions is restored to verify that everything works moving forward. Fixes qiskit-community#532
drewrisinger
reviewed
Nov 4, 2020
| @@ -37,6 +37,32 @@ jobs: | |||
| QISKIT_IN_PARALLEL: TRUE | |||
| run: tox -e py | |||
| if: runner.os == 'macOS' | |||
| tests-no-opt: | |||
There was a problem hiding this comment.
We really should break the GHA into separate scripts at some point
chriseclectic
approved these changes
Nov 10, 2020
mtreinish
added a commit
to mtreinish/qiskit-ignis
that referenced
this pull request
Nov 12, 2020
* Fix ignis without optional requirements installed In qiskit-community#500 type hints were added for the plotting functions using the optional matplotlib dependencies. This breaks ignis installations without matplotlib present since it's an optional dependency. Since type hints are really just for documentation and not necessary this commit just removes those problematic hints and uses the docstring to document the types. At the same time the testing job verifying ignis works without any optional dependencies that was lost in the migration from travis to github actions is restored to verify that everything works moving forward. (cherry picked from commit d9fe8f9)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #500 type hints were added for the plotting functions using the
optional matplotlib dependencies. This breaks ignis installations
without matplotlib present since it's an optional dependency. Since type
hints are really just for documentation and not necessary this commit
just removes those problematic hints and uses the docstring to document
the types.
At the same time the testing job verifying ignis works without any
optional dependencies that was lost in the migration from travis to
github actions is restored to verify that everything works moving
forward.
Details and comments
Fixes #532