Add double click element keyword #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Penploys
commented
Nov 29, 2021
Penploys
commented
- Add double click element keyword
- Add new button and form for double click in demo app
- Add double click system testing
atthaboon
reviewed
Nov 29, 2021
| @@ -57,6 +57,11 @@ async def press_keys(self, locator: str, *keys: str): | |||
| for key in keys: | |||
| await element.press(key) | |||
|
|
|||
| async def double_click_element(self, locator: str, noWaitAfter: str='False'): | |||
| element = await self.library_ctx.get_current_page().querySelector_with_selenium_locator(locator) | |||
| await element.dblclick() | |||
There was a problem hiding this comment.
Puppeteer not support dblclick
plz change to click with clickCount 2
atthaboon
reviewed
Nov 29, 2021
|
|
||
| Double Click Element | ||
| Open browser to test page http://127.0.0.1:7272/basic-html-elements.html | ||
| Double Click Element id=double_click_get_id |
There was a problem hiding this comment.
Could you and verify step for ensure that double click work as expect?
Due to some of library may not send mouse event as double click
There was a problem hiding this comment.
I suppose it's great to add it as Alias Keyword
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.