Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/abi: split abi class into encoder and decoder #203

Merged
merged 4 commits into from
Jan 5, 2023
Merged

Conversation

q9f
Copy link
Owner

@q9f q9f commented Jan 5, 2023

  • the access to Eth::Abi.encode and Eth::Abi.decode stays the same
  • Eth::Abi.encode_type is moved to Eth::Abi::Encoder.type
  • Eth::Abi.encode_primitive_type is moved to Eth::Abi::Encoder.primitive_type
  • Eth::Abi.decode_type is moved to Eth::Abi::Decoder.type
  • Eth::Abi.decode_primitive_type is moved to Eth::Abi::Decoder.primitive_type
  • Eth::Abi.signature is moved to Eth::Abi::Event.signature

@q9f q9f added the refactor Improving the architecture label Jan 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023

Codecov Report

Merging #203 (b48a4c2) into main (bb0ebde) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #203   +/-   ##
=======================================
  Coverage   99.76%   99.77%           
=======================================
  Files          73       77    +4     
  Lines        4336     4358   +22     
=======================================
+ Hits         4326     4348   +22     
  Misses         10       10           
Impacted Files Coverage Δ
lib/eth/abi.rb 100.00% <100.00%> (ø)
lib/eth/abi/decoder.rb 100.00% <100.00%> (ø)
lib/eth/abi/encoder.rb 100.00% <100.00%> (ø)
lib/eth/abi/event.rb 100.00% <100.00%> (ø)
lib/eth/abi/type.rb 100.00% <100.00%> (ø)
spec/eth/abi/decoder_spec.rb 100.00% <100.00%> (ø)
spec/eth/abi/encoder_spec.rb 100.00% <100.00%> (ø)
spec/eth/abi/event_spec.rb 100.00% <100.00%> (ø)
spec/eth/abi_spec.rb 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@q9f q9f merged commit 4e4ad54 into main Jan 5, 2023
@q9f q9f deleted the q9f/abi/refactor branch January 5, 2023 12:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improving the architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants