Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Decorator Metadata #10

Open
wants to merge 18 commits into
base: decorators
Choose a base branch
from
Open

Adds Decorator Metadata #10

wants to merge 18 commits into from

Commits on Mar 6, 2023

  1. Add Class and Class Element Decorators and accessor Keyword

    Updates
    
    - Refactor to use ClassElementDefinition more extensively
    - Separate parsing class elements and defining them so that we can
      control the order of definition and decorator application
    - Extract and centralize class element decoration into a single place
    - Fix completions in ClassDefinitionEvaluation (need to reset the env
      after each possible abrupt completion).
    - Refactor adding private methods to instance to pull directly from
      `Class.[[Elements]]`, so we don't have multiple sources of truth for
      the elements that are defined on a class. `Class.[[Elements]]` is the
      canonical source of truth after ClassDefinitionEvaluation, and any
      operations afterward such as instantiation should base themselves on
      that.
    - Refactor to use anonymous function syntax.
    Chris Garrett authored and pzuraq committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    14425b5 View commit details
    Browse the repository at this point in the history
  2. Non-normative fixes

    pzuraq committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    1f42b91 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bcd170c View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Configuration menu
    Copy the full SHA
    a2b63dd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5d556fe View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f604983 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Merge pull request #5 from pzuraq/remove-dynamic-home-object

    Remove dynamic [[HomeObject]] from decorator return values
    pzuraq committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    e86128e View commit details
    Browse the repository at this point in the history
  2. Merge pull request #7 from pzuraq/throw-error-if-initializer-is-not-c…

    …allable
    
    Throw an error if the value passed to `addInitializer` is not callable
    pzuraq committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    ca35c74 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #8 from pzuraq/set-add-initializer-function-name

    Set the name of the `addInitializer` function
    pzuraq committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    444a531 View commit details
    Browse the repository at this point in the history
  4. Call decorators with their natural this value.

    For more details, see this issue: tc39/proposal-decorators#487
    pzuraq committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    50ce824 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    39e6e35 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #11 from pzuraq/remove-set-function-name

    Remove setFunctionName from decorator application
    pzuraq committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    43b16ea View commit details
    Browse the repository at this point in the history
  7. Merge pull request #6 from pzuraq/call-decorators-with-correct-this

    Call decorators with the natural `this` value
    pzuraq committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    823f1bf View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Reverse initializer order

    pzuraq committed May 16, 2023
    Configuration menu
    Copy the full SHA
    c4465e4 View commit details
    Browse the repository at this point in the history
  2. Adds Decorator Metadata

    pzuraq committed May 16, 2023
    Configuration menu
    Copy the full SHA
    ceb4225 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    90938f8 View commit details
    Browse the repository at this point in the history
  4. Update spec based on feedback

    pzuraq committed May 16, 2023
    Configuration menu
    Copy the full SHA
    fb0852e View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. more feedback

    pzuraq committed May 17, 2023
    Configuration menu
    Copy the full SHA
    b5c0f4e View commit details
    Browse the repository at this point in the history