Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AVIF decoder (Part 1- this is not public or available yet) #8596

Merged
merged 14 commits into from
Aug 19, 2024

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Aug 16, 2024

This PR adds the ability to decoder AVIF files. It work but I'm keeping it private for now: we have to rely on libavif which is only available on conda-forge, which we cannot use. We'll try to make it available on the pytorch channel.
Until then, building with AVIF support is disabled by default, and _decode_avif is kept private.

Also, we always decode to RGB, e.g. an RGBA image still returns an RGB tensor. The decoder is mostly based on the official example https://github.com/AOMediaCodec/libavif/blob/main/examples/avif_example_decode_memory.c

Copy link

pytorch-bot bot commented Aug 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8596

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (7 Unrelated Failures)

As of commit 640a3d7 with merge base 0a0f34b (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@NicolasHug NicolasHug changed the title [WIP] Add AVIF decoder Add AVIF decoder (Part 1- this is not public or available yet) Aug 19, 2024
@NicolasHug NicolasHug marked this pull request as ready for review August 19, 2024 16:06
@NicolasHug NicolasHug merged commit 9e78fe2 into pytorch:main Aug 19, 2024
67 of 74 checks passed
@NicolasHug NicolasHug deleted the avif branch August 19, 2024 17:11
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Sep 2, 2024
…t) (#8596)

Reviewed By: ahmadsharif1

Differential Revision: D62032046

fbshipit-source-id: 729f46ef25ef0beb31ff9783c3db749a733bf2a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants