Remove reference consistency tests #8023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8023
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 3 Unrelated FailuresAs of commit 123b73d with merge base 1d646d4 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
NicolasHug
approved these changes
Oct 5, 2023
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
Reviewed By: vmoens Differential Revision: D50789101 fbshipit-source-id: 706aa0f811fd518522753206fc05097676e0d697
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reiterating from #8013 (comment):
We have consistency tests against v1 as part of our regular v2 tests. Meaning, the only things left in here are transforms that are not part of v1. These are the transforms that are part of our reference scripts and became part of the v2 API. The tests for them are
vision/test/test_transforms_v2_consistency.py
Line 37 in 67f3ce2
vision/test/test_transforms_v2_consistency.py
Line 142 in 67f3ce2
As for all the other consistency tests, these tests had the most value during the heavy development to avoid breaking consistency. Now that the API is stable and we need to keep BC anyway and the tests have been running smoothly for almost a year, their value is fairly low.
Plus, #7724 and the sister PRs enabled the v2 transforms in the references. In the long term, we'll likely drop support for transforms v1 in the reference scripts.
My vote is out for removing them completely hence this PR.
cc @vfdev-5