mark SBU download as not accessible in tests #7970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7970
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 713219f with merge base 4cb3d80 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pmeier
commented
Sep 18, 2023
| @@ -391,4 +391,4 @@ def test_url_is_not_accessible(url): | |||
| If you see this test failing, find the offending dataset in the parametrization and move it to | |||
| ``test_url_is_accessible``. | |||
| """ | |||
| retry(lambda: assert_url_is_accessible(url)) | |||
| assert_url_is_accessible(url) | |||
There was a problem hiding this comment.
Driveby. Since we assert that the URL is not accessible by trying and xfailing afterwards, there is no need for retries.
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
Reviewed By: matteobettini Differential Revision: D49600773 fbshipit-source-id: c5d27b90c3548b9e5253fba7542bf16b5bcfabad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #7964. Since final RC for upcoming release is already cut, we can just leave it in the "not accessible" list until next release. Maybe it comes up again.