Meta implementation for nms #7944
Conversation
Signed-off-by: Edward Z. Yang <ezyang@meta.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7944
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7c858e1 with merge base f2b6f43 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
I'll approve to unblock and let you merge when you need to. Following up on #7448 (comment) about testing, where should we look at to make sure this is working as intended (and to make sure we don't break it later)?
|
re testing, @zou3519's testing work is nearly there, but I need to land some more things to PyTorch to make it work with torchvision. WIP PRs: pytorch/pytorch#108936 pytorch/pytorch#108935 pytorch/pytorch#108929 |
|
Hey @ezyang! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Summary: Signed-off-by: Edward Z. Yang <ezyang@meta.com> Reviewed By: matteobettini Differential Revision: D49600795 fbshipit-source-id: 9316979b8df85d2fb3fa4d6c2c3573c8a0b1d0e3 Co-authored-by: Philip Meier <github.pmeier@posteo.de>
There was a vision hash update which led to fewer graph breaks. This seems expected to me (because the hash update included pytorch/vision#7944 and nms is used in maskrcnn). Test Plan: - wait for ci [ghstack-poisoned]
There was a vision hash update which led to fewer graph breaks. This seems expected to me (because the hash update included pytorch/vision#7944 and nms is used in maskrcnn). Test Plan: - wait for ci ghstack-source-id: 3e43580cab52245e7d87b407508fc5751482c620 Pull Request resolved: #110160
There was a vision hash update which led to fewer graph breaks. This seems expected to me (because the hash update included pytorch/vision#7944 and nms is used in maskrcnn). Test Plan: - wait for ci Pull Request resolved: #110160 Approved by: https://github.com/ezyang, https://github.com/Chillee
Signed-off-by: Edward Z. Yang ezyang@meta.com