Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port tests for F.gaussian_blur GaussianBlur #7935

Merged
merged 4 commits into from
Sep 6, 2023

Conversation

pmeier
Copy link
Contributor

@pmeier pmeier commented Sep 6, 2023

Follow-up to #7887.

cc @vfdev-5

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 6, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7935

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 7 Unrelated Failures

As of commit 5919483 with merge base 4ac707a (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

)
@pytest.mark.parametrize("dtype", [torch.float32, torch.float64, torch.float16])
@pytest.mark.parametrize("device", cpu_and_cuda())
def test_functional_image_correctness(self, kernel_size, sigma, canvas_size, dtype, device):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've refactored this from

def test_gaussian_blur(device, image_size, dt, ksize, sigma, fn):

which is hard to understand and also does some unnecessary work just to skip later.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmeier!

test/test_transforms_v2_refactored.py Outdated Show resolved Hide resolved
@pmeier pmeier merged commit 90913fb into pytorch:main Sep 6, 2023
54 of 62 checks passed
@pmeier pmeier deleted the port/gaussian-blur branch September 6, 2023 11:49
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Sep 26, 2023
Reviewed By: matteobettini

Differential Revision: D49600788

fbshipit-source-id: 8afacb9e7dd6eba19f2212d8efa260f733bcb473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants