test output_format in video datasets #7879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Aug 24, 2023
|
|
||
| def __init__(self, *args, **kwargs): | ||
| super().__init__(*args, **kwargs) | ||
| self.dataset_args = self._set_default_frames_per_clip(self.dataset_args) | ||
|
|
||
| def _set_default_frames_per_clip(self, inject_fake_data): | ||
| def _set_default_frames_per_clip(self, dataset_args): |
There was a problem hiding this comment.
Although the logic is correct, we used the wrong name here. See L669 in the constructor for the call.
Comment on lines
+190
to
+192
| clip_length_in_frames=self.num_frames, | ||
| frames_between_clips=self.step, | ||
| frame_rate=self.frame_rate, |
There was a problem hiding this comment.
I found this pretty hard to read without these being keyword args.
NicolasHug
approved these changes
Aug 24, 2023
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
Summary: (Note: this ignores all push blocking failures!) Reviewed By: matteobettini Differential Revision: D48900404 fbshipit-source-id: 015ca49dd030e3734ad7a9d088ea454ffc2bf018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into #7875, I realized we don't test for the correct output format of our video datasets. This PR adds a small test for that as well some QoL improvements I found along the way.