Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced ConvertImageDtype by ToDtype in reference scripts #7862

Merged
merged 7 commits into from
Aug 24, 2023
Merged

Replaced ConvertImageDtype by ToDtype in reference scripts #7862

merged 7 commits into from
Aug 24, 2023

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Aug 21, 2023

Description:

  • Replaced ConvertImageDtype by ToDtype in reference scripts
  • Locally tested the execution of modified examples

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 21, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7862

Note: Links to docs will display an error until the docs builds have been completed.

❌ 26 New Failures, 8 Unrelated Failures

As of commit 6e19f49 with merge base 4491ca2 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

NicolasHug
NicolasHug reviewed Aug 22, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vfdev-5 , looks good

references/detection/transforms.py Outdated Show resolved Hide resolved
references/segmentation/transforms.py Outdated Show resolved Hide resolved
NicolasHug
NicolasHug approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vfdev-5 !

references/segmentation/v2_extras.py
@@ -78,6 +78,6 @@ def _coco_detection_masks_to_voc_segmentation_mask(self, target):
def forward(self, image, target):
segmentation_mask = self._coco_detection_masks_to_voc_segmentation_mask(target)
if segmentation_mask is None:
segmentation_mask = torch.zeros(v2.functional.get_spatial_size(image), dtype=torch.uint8)
segmentation_mask = torch.zeros(v2.functional.get_size(image), dtype=torch.uint8)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah good catch, thanks

@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 23, 2023 22:41 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 23, 2023 22:41 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 23, 2023 22:41 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 23, 2023 22:41 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 23, 2023 22:41 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 23, 2023 22:41 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 23, 2023 22:42 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 23, 2023 22:42 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 23, 2023 22:42 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 23, 2023 22:42 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 24, 2023 03:12 — with GitHub Actions Inactive
@NicolasHug NicolasHug merged commit 9f0afd5 into pytorch:main Aug 24, 2023
10 of 33 checks passed
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 24, 2023 15:51 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 24, 2023 15:51 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 24, 2023 15:52 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 24, 2023 15:52 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 24, 2023 15:52 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 24, 2023 15:52 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 24, 2023 15:52 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 24, 2023 15:52 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 24, 2023 15:52 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 24, 2023 15:52 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 deleted the replace_ConvertImageDtype branch August 24, 2023 15:53
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 24, 2023 15:58 — with GitHub Actions Inactive
facebook-github-bot pushed a commit that referenced this pull request Sep 6, 2023
@NicolasHug @facebook-github-bot
[fbsync] Replaced ConvertImageDtype by ToDtype in reference scripts (#…
2117e04 
…7862)

Summary: (Note: this ignores all push blocking failures!)

Reviewed By: matteobettini

Differential Revision: D48900394

fbshipit-source-id: b4c93e890c8565bbba16211e3a7842a972b259a7

Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed code quality module: reference scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vfdev-5 @NicolasHug @facebook-github-bot