-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove import-time warning for v2 namespaces #7853
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7853
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New Failures, 1 Unrelated FailureAs of commit 3fad5be with merge base 87d54c4 (): NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Summary: (Note: this ignores all push blocking failures!) Reviewed By: matteobettini Differential Revision: D48900399 fbshipit-source-id: d6752725c98312a4460e5784de09b93b4523d8f8
We have addressed a lot of things we were uncertain about (I'll udpate #7319 soon), and today we're fairly confident that there will not be future disruptive public changes to the v2 APIs.
We're still keeping them as Beta for the next release, but we don't think the import-time warnings are warranted anymore. This will allow us to promote and encourage v2 APIs more smoothly.
cc @vfdev-5