separate transforms v2 legacy test utils #7842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: test/test_prototype_transforms.py test/test_transforms_v2.py test/test_transforms_v2_functional.py
NicolasHug
approved these changes
Aug 18, 2023
|
|
||
|
|
||
| def make_bounding_box( | ||
| def make_bounding_boxes( |
There was a problem hiding this comment.
I'd be nice if we could get rid of the unused parameters / functionality. For example we shouldn't need batch_dims anymore? Maybe there are others. But we can do that in a follow-up PR.
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
Summary: (Note: this ignores all push blocking failures!) Reviewed By: matteobettini Differential Revision: D48900374 fbshipit-source-id: 69750e3297c88df98e5bb523364317ca05ec4722
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does two things:
common_utils.pyinto a separate module.make_bounding_boxtomake_bounding_boxesto align it with the name of the datapoint. Themake_bounding_boxeslegacy utility was renamed tomake_multiple_bounding_boxes, since we don't care about breaking the naming scheme there.