cleanup spatial_size -> canvas_size #7783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
added
module: tests
other
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7783
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 5ec3b24: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
NicolasHug
approved these changes
Aug 1, 2023
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
Reviewed By: matteobettini Differential Revision: D48642317 fbshipit-source-id: 536290b00dbf1f613cdfb71c56eb4bab19f9771b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged #7734 too soon and only afterwards saw my botched attempt of resolving the merge conflicts in the common test utilities. We are putting back
spatial_sizehere for the components that are only used by the legacy v2 tests. Meaning, they will be removed when we no longer have legacy tests.I'll send a PR to remove this one and #7734 from git blame afterwards.