Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup ported v2 tests #7723

Closed
wants to merge 10 commits into from
Closed

cleanup ported v2 tests #7723

wants to merge 10 commits into from

Conversation

pmeier
Copy link
Contributor

@pmeier pmeier commented Jul 6, 2023

This does couple of things:

  1. Enable make_image to return a fake channels last image. For PyTorch core only 4D tensors can be channels last, but most of the time we test 3D ones. Setting memory_format=torch.channels_last without batch dims, will now return the memory laid out correctly.
  2. Fix the naming of the test helper to create datapoints.BoundingBoxes. We currently have
  3. Remove some obsolete helper functions and tests from test/test_transforms_v2_functional.py
  4. Port the remaining correctness tests for F.resize from test/test_transforms_v2_functional.py to test/test_transforms_v2_refactored.py
  5. Refactor the affine bounding box helper to also accept expand=True and datapoints.BoundingBoxes directly, rather than a torch.Tensor and explicit metadata.
  6. Use the result from 5. to implement reference tests for F.resize and F.rotate

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 6, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7723

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 37b1458 with merge base 4cba51c (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pmeier pmeier marked this pull request as ready for review August 16, 2023 14:05
Conflicts:
	test/test_transforms_v2_functional.py
	test/test_transforms_v2_refactored.py
@pmeier
Copy link
Contributor Author

pmeier commented Aug 28, 2023

Superseded by a few smaller PRs.

@pmeier pmeier closed this Aug 28, 2023
@pmeier pmeier deleted the port/cleanup branch August 28, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants