-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup ported v2 tests #7723
Closed
Closed
cleanup ported v2 tests #7723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7723
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 37b1458 with merge base 4cba51c (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pmeier
commented
Aug 16, 2023
Co-authored-by: vfdev-5 <vfdev.5@gmail.com>
Conflicts: test/test_transforms_v2_functional.py test/test_transforms_v2_refactored.py
Superseded by a few smaller PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does couple of things:
make_image
to return a fake channels last image. For PyTorch core only 4D tensors can be channels last, but most of the time we test 3D ones. Settingmemory_format=torch.channels_last
without batch dims, will now return the memory laid out correctly.datapoints.BoundingBoxes
. We currently havevision/test/common_utils.py
Line 644 in e0e6f7e
This is what we should use in terms of functionality
vision/test/common_utils.py
Line 719 in e0e6f7e
This is the legacy function that creates an iterator over multiple
datapoints.BoundingBoxes
.test/test_transforms_v2_functional.py
F.resize
fromtest/test_transforms_v2_functional.py
totest/test_transforms_v2_refactored.py
expand=True
anddatapoints.BoundingBoxes
directly, rather than atorch.Tensor
and explicit metadata.F.resize
andF.rotate