Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove center unsetting if expand=True #7715

Merged
merged 1 commit into from
Jul 3, 2023
Merged

remove center unsetting if expand=True #7715

merged 1 commit into from
Jul 3, 2023

Conversation

pmeier
Copy link
Contributor

@pmeier pmeier commented Jul 3, 2023 •
edited by pytorch-bot bot
Loading

Closes #7714 and follow-up to #7271.

cc @vfdev-5

@pmeier pmeier requested review from NicolasHug and vfdev-5 July 3, 2023 10:02
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 3, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7715

Note: Links to docs will display an error until the docs builds have been completed.

❌ 15 New Failures

As of commit 0c0ea5e:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pmeier pmeier mentioned this pull request Jul 3, 2023
Merged
NicolasHug
NicolasHug approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip. So our warning is technically wrong lol.

@pmeier pmeier merged commit 43030cb into pytorch:main Jul 3, 2023
46 of 61 checks passed
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Jul 3, 2023
@NicolasHug @facebook-github-bot
[fbsync] remove center unsetting if expand=True (#7715)
4ba14c6 
Reviewed By: vmoens

Differential Revision: D47186565

fbshipit-source-id: 47318e0c951cece0a9a5f6085b3eceaf5a986d59
@pmeier pmeier deleted the rotate-center branch July 17, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

@vfdev-5 vfdev-5 Awaiting requested review from vfdev-5

Assignees
No one assigned
Labels
cla signed module: transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

transforms v2 rotate can create different sizes between tensors and PIL with expand=True
3 participants
@pmeier @NicolasHug @facebook-github-bot