Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable Windows GPU CI on GHA #7498

Merged
merged 19 commits into from
May 2, 2023
Merged

enable Windows GPU CI on GHA #7498

merged 19 commits into from
May 2, 2023

Conversation

pmeier
Copy link
Contributor

@pmeier pmeier commented Apr 4, 2023

Follow-up to #7475 (comment).

cc @seemethere

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 4, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7498

Note: Links to docs will display an error until the docs builds have been completed.

❗ 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

❌ 25 New Failures, 1 Unrelated Failure

As of commit 8ed4785:

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base a33ce08:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pmeier
Copy link
Contributor Author

pmeier commented May 1, 2023

nvjpeg is now there: https://github.com/pytorch/vision/actions/runs/4849919333/jobs/8642356230#step:9:233

However, it seems something is off with the path as we cannot load the image.pyd: https://github.com/pytorch/vision/actions/runs/4849919333/jobs/8642356230#step:9:801

@pmeier pmeier mentioned this pull request May 1, 2023
@pmeier
Copy link
Contributor Author

pmeier commented May 1, 2023

In c12e4f7 I removed the Windows GPU tests from CircleCI. Although we usually had a grace period, I don't think we need one here. The grace period for the CPU workflow is already over (#7526) and this PR only enables the GPU runs. If the CI is green here, I don't expect any regressions for this later on. LMK if you think otherwise so I can revert that commit.

@pmeier pmeier marked this pull request as ready for review May 1, 2023 21:19
@pmeier pmeier requested review from NicolasHug and atalman May 1, 2023 21:19
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip

However, it seems something is off with the path as we cannot load the image.pyd

Just to confirm, is this comment still relevant? I'm seeing the test/test_image.py::test_decode_jpeg_cuda tests properly passing (as well as the cuda ones in test_models.py) so as far as tests go, this PR LGTM.

@pmeier
Copy link
Contributor Author

pmeier commented May 2, 2023

No, comment is outdated. This was fixed in 5c0da2e.

@pmeier pmeier merged commit 9bc094e into pytorch:main May 2, 2023
@pmeier pmeier deleted the win-ci-gpu branch May 2, 2023 10:26
@github-actions
Copy link

github-actions bot commented May 2, 2023

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request May 15, 2023
Reviewed By: vmoens

Differential Revision: D45522826

fbshipit-source-id: fb832f29c09ade1d7a796ebf31d35d74ed600aff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants