Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: Remove pin for jpeg, numpy #3647

Merged
merged 4 commits into from
Apr 10, 2021

Conversation

seemethere
Copy link
Member

These may no longer be necessary due to the default anaconda channel
having the necessary packages now.

Signed-off-by: Eli Uriegas eliuriegas@fb.com

These may no longer be necessary due to the default anaconda channel
having the necessary packages now.

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this a try!

@fmassa fmassa merged commit e8dded4 into pytorch:master Apr 10, 2021
facebook-github-bot pushed a commit that referenced this pull request Apr 13, 2021
Summary:
* packaging: Remove pin for jpeg, numpy

These may no longer be necessary due to the default anaconda channel
having the necessary packages now.

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

* Update packaging/torchvision/meta.yaml

Reviewed By: NicolasHug

Differential Revision: D27706942

fbshipit-source-id: 64476f429ad8fd5ea110df3bd62b816157bdae11

Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
@kylevedder
Copy link

This fix impacted pytorch's conda channel for PyTorch 1.10, but not earlier versions. For those who want a work-around for earlier versions, e.g. opencv 3 and pytorch 1.8.1, this worked for me:

conda install pip python=3.8 pytorch::pytorch=1.8.1 cudatoolkit=11.1 cudatoolkit-dev=11.1 opencv=3.4.9 -c pytorch -c nvidia -c anaconda -c conda-forge -c defaults
# Manually specify all the requirements for pytorch except jpeg pegged.
# These requirements were found via `conda search --info torchvision=0.9 -c pytorch` and
# then matching the build against the python version (3.8) and CUDA version (11.1)
conda install ffmpeg>=4.2 libpng numpy >=1.11 pillow >=4.1.1
# Pro gamer move: force install without dependency checking via pip. conda 
# will *not* let you force install despite conflicts (--no-deps and --force don't work), see
# https://github.com/conda/conda/issues/2980
pip install torchvision==0.9.1 --no-deps

If you want a different version of PyTorch this should work, but make sure you update the torchvision version to correspond to the new pytorch version and double check the dependency versions.
NB: be very careful that these installs are not later disrupted by other packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conda install incompatible with opencv for python 3.9
5 participants