Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dtype static list with a reference to data type doc #2937

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

hippocookie
Copy link
Contributor

@hippocookie hippocookie commented Jun 17, 2024

Fixes #2901

Description

in the pytorch dtype doc(link in below) is torch.bfloat16, but in tutorial istorch.bfloat , this might be mislead user to created dtype=torch.bfloat and get an error, might be better to make improvements:

  • Using doc link replace with static dtype explanation

tutorial link: https://pytorch.org/tutorials/beginner/introyt/tensors_deeper_tutorial.html
doc link: https://pytorch.org/docs/stable/tensor_attributes.html#torch.dtype

tutorial is torch.bfloat
image

Got error when try to create
image

Should be dtype=torch.bfloat16
image

** Test Result: Local compile pages **

image

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @albanD @sekyondaMeta @svekars @kit1980 @brycebortree

Copy link

pytorch-bot bot commented Jun 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2937

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 08bd190 with merge base 91540a8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @hippocookie!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions github-actions bot added core Tutorials of any level of difficulty related to the core pytorch functionality docathon-h1-2024 easy labels Jun 17, 2024
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@hippocookie hippocookie marked this pull request as ready for review June 17, 2024 06:04
@svekars svekars added the website Issues related to website rendering label Jun 18, 2024
@svekars svekars merged commit ef9750a into pytorch:main Jun 18, 2024
18 checks passed
ignaciobartol pushed a commit to ignaciobartol/tutorials that referenced this pull request Jun 24, 2024
…2937)

Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
ignaciobartol pushed a commit to ignaciobartol/tutorials that referenced this pull request Jun 24, 2024
…2937)

Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed core Tutorials of any level of difficulty related to the core pytorch functionality docathon-h1-2024 easy website Issues related to website rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test the Running the Tutorial Code tutorial
3 participants