Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting a Model from PyTorch to ONNX tutorial - Docathon #2935

Merged
merged 10 commits into from
Jun 18, 2024

Conversation

diningeachox
Copy link
Contributor

@diningeachox diningeachox commented Jun 16, 2024

Fixes #2902

Description

Adds a timing script to the tutorial page to compare inference times between pytorch and ONNX models.
Fixed one of the external links at the bottom of the page.
Displays low-res and super-res images next to each other so readers can see a comparison.

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @xadupre @sekyondaMeta @svekars @kit1980 @brycebortree, @titaiwangms and @thiagocrepaldi

Copy link

pytorch-bot bot commented Jun 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2935

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit c42a711 with merge base ef9750a (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @diningeachox!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions github-actions bot added docathon-h1-2024 easy onnx Issues relating to ONNX labels Jun 16, 2024
@svekars svekars added onnx Issues relating to ONNX and removed onnx Issues relating to ONNX labels Jun 17, 2024
@svekars
Copy link
Contributor

svekars commented Jun 17, 2024

Copy link
Contributor

@titaiwangms titaiwangms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@svekars svekars merged commit be898cb into pytorch:main Jun 18, 2024
17 of 18 checks passed
ignaciobartol pushed a commit to ignaciobartol/tutorials that referenced this pull request Jun 24, 2024
* added timing comparison
---------

Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
ignaciobartol pushed a commit to ignaciobartol/tutorials that referenced this pull request Jun 24, 2024
* added timing comparison
---------

Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test the Exporting a Model from PyTorch to ONNX tutorial
5 participants