Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DQN Tutorial #2934

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Improve DQN Tutorial #2934

merged 4 commits into from
Jun 18, 2024

Conversation

alperenunlu
Copy link
Contributor

@alperenunlu alperenunlu commented Jun 16, 2024 •
edited by pytorch-bot bot
Loading

Fixes #2897

Description

Added MPS support and link to original paper.

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @vmoens @nairbv @sekyondaMeta @svekars @kit1980 @brycebortree

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 16, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2934

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 42fe906 with merge base be898cb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions bot added docathon-h1-2024 easy rl Issues related to reinforcement learning tutorial, DQN, and so on labels Jun 16, 2024
@svekars svekars requested a review from vmoens June 17, 2024 15:12
vmoens
vmoens reviewed Jun 18, 2024
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good, before merging I would make sure that the script runs ok with mps device. Can you share a learning curve if you have access to a machine like that?

@alperenunlu
Copy link
Contributor Author

Sure

Figure_1

@vmoens

vmoens
vmoens approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for running the code!

@svekars svekars merged commit 0740801 into pytorch:main Jun 18, 2024
20 checks passed
ignaciobartol pushed a commit to ignaciobartol/tutorials that referenced this pull request Jun 24, 2024
@alperenunlu @svekars @ignaciobartol
Improve DQN Tutorial (pytorch#2934)
423c303 
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
ignaciobartol pushed a commit to ignaciobartol/tutorials that referenced this pull request Jun 24, 2024
@alperenunlu @svekars @ignaciobartol
Improve DQN Tutorial (pytorch#2934)
3095846 
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
cla signed docathon-h1-2024 easy rl Issues related to reinforcement learning tutorial, DQN, and so on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test the Reinforcement Learning (DQN) tutorial
4 participants
@alperenunlu @vmoens @svekars @facebook-github-bot