Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Redirect old Loading data in PyTorch to newer Datasets & DataLoaders #2922

Merged
merged 19 commits into from
Jun 13, 2024

Conversation

loganthomas
Copy link
Contributor

@loganthomas loganthomas commented Jun 10, 2024

Fixes #2905

Description

This recipe specifically is quite outdated and likely does not answer what a user is trying to learn. There is a better tutorial on this topic: https://pytorch.org/tutorials/beginner/basics/data_tutorial.html - we could consider deprecating and creating a redirect from this tutorial to the data_tutorial.html.
Followed the above guidance to deprecate old and point to new content

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @sekyondaMeta @svekars @kit1980 @brycebortree

Copy link

pytorch-bot bot commented Jun 10, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2922

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 506b16d with merge base 7a44230 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

.jenkins/validate_tutorials_built.py Outdated Show resolved Hide resolved
recipes_source/recipes_index.rst Outdated Show resolved Hide resolved
recipes_source/recipes_index.rst Outdated Show resolved Hide resolved
recipes_source/recipes/README.txt Outdated Show resolved Hide resolved
@loganthomas
Copy link
Contributor Author

thank you @svekars 🎉

@loganthomas
Copy link
Contributor Author

@pytorchbot merge

Copy link

pytorch-bot bot commented Jun 12, 2024

This PR needs to be approved by an authorized maintainer before merge.

@svekars svekars merged commit 63f987d into pytorch:main Jun 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test the Loading data in PyTorch tutorial
3 participants