Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CUDA graph, Tensor Core and Core pinning explaination #2912

Merged
merged 7 commits into from
Jun 12, 2024

Conversation

orion160
Copy link
Contributor

@orion160 orion160 commented Jun 7, 2024

Copy link

pytorch-bot bot commented Jun 7, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2912

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d2b53a3 with merge base 67819bb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@orion160
Copy link
Contributor Author

orion160 commented Jun 8, 2024

@msaroufim resolved

@msaroufim
Copy link
Member

@pytorchbot merge

@orion160
Copy link
Contributor Author

orion160 commented Jun 8, 2024

Hmmmm it seems that the spell checker doesn't like that comment

# and will set torch.backends.cuda.matmul.allow_tf32 = True if available

@msaroufim
Copy link
Member

Id just get rid of the line

@msaroufim
Copy link
Member

@pytorchbot merge

1 similar comment
@msaroufim
Copy link
Member

@pytorchbot merge

Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the updates. I added a few suggestions. Also, you can check rendering here.

recipes_source/recipes/tuning_guide.py Outdated Show resolved Hide resolved
recipes_source/recipes/tuning_guide.py Outdated Show resolved Hide resolved
recipes_source/recipes/tuning_guide.py Outdated Show resolved Hide resolved
recipes_source/recipes/tuning_guide.py Outdated Show resolved Hide resolved
recipes_source/recipes/tuning_guide.py Outdated Show resolved Hide resolved
recipes_source/recipes/tuning_guide.py Outdated Show resolved Hide resolved
orion160 and others added 6 commits June 10, 2024 16:43
Added cuda graph explaination

Added core pinning section

Added tensor core usage section
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
@orion160
Copy link
Contributor Author

@svekars Thanks for the comments!

@svekars svekars merged commit a232ff3 into pytorch:main Jun 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance Tuning Guide is very out of date
4 participants